Move desktop search and bell to TopBar - #53
Conversation
Extracts desktop search and notifications from `Sidebar` into a new `TopBar` component and wires it into `AppShell`, keeping mobile behavior in `MobileTopBar` and simplifying sidebar props/usages. Also fixes a command palette hotkey closure issue by adding dependencies to the `useHotkeys` binding so `mod+k` properly toggles open and closed state.
✅ Deploy Preview for overup-app ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
Next review available in: 40 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![amazon-q-developer[bot]](https://avatars.githubusercontent.com/in/1220912?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR successfully extracts the desktop search and notification bell from Sidebar to a new TopBar component, improving separation of concerns. The CommandPalette hotkey fix correctly addresses the closure issue by adding dependencies to the useHotkeys callback.
Critical Issue:
- Fix the deprecated
navigator.platformAPI in TopBar.tsx to ensure reliable Mac detection across browsers
Once the deprecated API is addressed, this refactoring will be ready to merge.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
| onSearch: (seed?: string) => void; | ||
| } | ||
|
|
||
| const IS_MAC = /Mac|iPhone|iPad/.test(navigator.platform); |
There was a problem hiding this comment.
🛑 Deprecated API: navigator.platform is deprecated and may not work in all browsers. Use navigator.userAgentData or navigator.userAgent for more reliable platform detection.
| const IS_MAC = /Mac|iPhone|iPad/.test(navigator.platform); | |
| const IS_MAC = typeof navigator !== 'undefined' && | |
| (navigator.userAgentData?.platform?.toLowerCase().includes('mac') ?? | |
| /Mac|iPhone|iPad/.test(navigator.userAgent)); |
1 participant
Extracts desktop search and notifications from
Sidebarinto a newTopBarcomponent and wires it intoAppShell, keeping mobile behavior inMobileTopBarand simplifying sidebar props/usages. Also fixes a command palette hotkey closure issue by adding dependencies to theuseHotkeysbinding somod+kproperly toggles open and closed state.