London | 26-ITP-May | Martin Mwaka | Sprint 3 | Quote generator#1275
Open
Temceo wants to merge 7 commits into
Open
London | 26-ITP-May | Martin Mwaka | Sprint 3 | Quote generator#1275Temceo wants to merge 7 commits into
Temceo wants to merge 7 commits into
Conversation
Temceo
added
🏕 Priority Mandatory
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
Jul 27, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Great work, I have some comments for places you could improve further
| @@ -1,3 +1,94 @@ | |||
| const newQuoteBtn = document.querySelector("#new-quote"); | |||
There was a problem hiding this comment.
If you are using IDs, is there a better method to use than querySelector?
| let countdownIntervalId = null; | ||
|
|
||
| // only show quotes that have not yet been seen | ||
| const getUnseenQuotes = () => { |
There was a problem hiding this comment.
This is a good idea, but is there an efficient way to get unseen quotes using a set that does not require a do-while loop?
|
|
||
| const startCountDown = () => { | ||
| let timeLeft = INTERVAL_DURATION_MS / 1000; | ||
| autoPlayStatus.innerText = `auto-play:ON - Quote will change in ${timeLeft} seconds`; |
There was a problem hiding this comment.
User feedback like this is nice, well done
LonMcGregor
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
Complete the quote generator challenge (html, css, javaScript)