Birmingham | 26-ITP-May | Ogbemi Mene | Sprint 2 | Module data groups/sprint2 - #1281
Open
meneogbemi42-bit wants to merge 16 commits into
Open
Birmingham | 26-ITP-May | Ogbemi Mene | Sprint 2 | Module data groups/sprint2#1281meneogbemi42-bit wants to merge 16 commits into
meneogbemi42-bit wants to merge 16 commits into
Conversation
added 13 commits
July 22, 2026 12:53
meneogbemi42-bit
changed the title
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
meneogbemi42-bit
added
the
Needs Review
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
Jul 27, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Well done on the tasks, your tests pass. Congrats on completing the stretch task!
Remember to remove your "todo" from your tests once you've implemented everything. then the task will be complete
LonMcGregor
added
Reviewed
Remove todo test for contains on empty object.
Removed a placeholder test for country currency code lookup.
Removed a pending test case for tally function on empty array.
meneogbemi42-bit
added
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR implements Sprint 2 solutions, adds tests, fixes several bugs, and improves edge-case handling. Ready for review after a few small cleanups.