Checks for refresh token properly - #17
Open
Matt-Carre wants to merge 5 commits into
Open
Conversation
Matt-Carre
force-pushed
the
not_open_browser
branch
5 times, most recently
from
July 23, 2026 08:11
a3ee017 to
4ee6c6e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #17 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 96 110 +14
=========================================
+ Hits 96 110 +14 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Matt-Carre
force-pushed
the
not_open_browser
branch
2 times, most recently
from
July 24, 2026 08:05
d978175 to
e9c087a
Compare
Merged
Matt-Carre
force-pushed
the
not_open_browser
branch
2 times, most recently
from
July 24, 2026 09:01
cafb7d9 to
b429881
Compare
Matt-Carre
force-pushed
the
not_open_browser
branch
3 times, most recently
from
July 24, 2026 09:35
1cdb2a1 to
30821fd
Compare
Matt-Carre
force-pushed
the
not_open_browser
branch
from
July 27, 2026 08:49
30821fd to
8755a47
Compare
Matt-Carre
force-pushed
the
not_open_browser
branch
from
July 27, 2026 10:47
8755a47 to
dc82761
Compare
TBThomas56
reviewed
Jul 28, 2026
TBThomas56
reviewed
Jul 28, 2026
Collaborator
|
commit feat(tests) has a conventional commit test(): |
TBThomas56
reviewed
Jul 28, 2026
TBThomas56
reviewed
Jul 28, 2026
TBThomas56
reviewed
Jul 28, 2026
| ) | ||
| case False: | ||
| token: dict[str, str] = keycloak_openid.refresh_token( # pyright: ignore | ||
| str(os.environ.get("REFRESHTOKEN")) # pyright: ignore |
Collaborator
There was a problem hiding this comment.
pyright ignore brings in a lot of checking. recommend you use a class for the TokenResponse
from typing import Any, TypedDict, cast
class TokenResponse(TypedDict):
access_token: str
refresh_token: str
refresh_expires_in: int
token = cast(TokenResponse, keycloak_openid.token(...),)
TBThomas56
reviewed
Jul 28, 2026
| redirect_uri=f"http://localhost:{port}/", | ||
| code_verifier=code_verifier, | ||
| ) | ||
| match open_auth_url(auth_url, port): |
Collaborator
There was a problem hiding this comment.
match on a bool can be replaced by if-else
TBThomas56
reviewed
Jul 28, 2026
| try: | ||
| httpd.handle_request() | ||
| os.environ["AUTH"] = httpd.auth_code | ||
| dotenv.set_key("src/.env", "AUTH", httpd.auth_code) |
Collaborator
There was a problem hiding this comment.
somewhere in a script or test it is worth making sure the key has appropriate permissions - chmod 600
TBThomas56
reviewed
Jul 28, 2026
| finally: | ||
| httpd.socket.shutdown(socket.SHUT_RDWR) | ||
| httpd.server_close() | ||
| def open_auth_url(auth_url: str, port: int) -> bool: |
Collaborator
There was a problem hiding this comment.
can break the function up to have *check if it is valid" seprately - this explains the open_auht_url function and makes the subsequent testing much easier.
TBThomas56
reviewed
Jul 28, 2026
TBThomas56
reviewed
Jul 28, 2026
| ) | ||
| case False: | ||
| token: dict[str, str] = keycloak_openid.refresh_token( # pyright: ignore | ||
| str(os.environ.get("REFRESHTOKEN")) # pyright: ignore |
Collaborator
There was a problem hiding this comment.
Error handling when REFRESHTOKEN equals none / empty string etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, please look at this second
Currently adds a checker to see if we have a refresh token, then uses this as opposed to opening a browser every time.
Further, updates the copier template and pre-commit copier template, as despite it working before, I realise now that given the updates to the workflow, that jinja formatting and yaml formatting do not mix - {{inputs.parameters.extension}} is now being interpreted as raw text, while {{repo_name}} is interpreted as a variable copier can use.