docs: Add stale flag detection documentation - #8142
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
📝 WalkthroughWalkthroughAdded a new Stale Flag Detection documentation page covering detection rules, configuration, system tags, plan requirements, permanent-tag exclusions, and cleanup workflow. Existing flag lifecycle and code-reference documentation now links to it, and tagging guidance clarifies that permanent tags exclude flags from stale detection. Estimated code review effort: 2 (Simple) | ~10 minutes Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
adamvialpando
left a comment
adamvialpando
left a comment
There was a problem hiding this comment.
Overall I like the docs additions and changes. My only question is with the flag lifecycle additions placement.
|
|
||
| Short lived flags are typically used for the following use-scenarios: | ||
|
|
||
| Flagsmith can automatically flag features that have not been changed for a configurable period of time — see [Stale Flag Detection](/managing-flags/stale-flags). |
There was a problem hiding this comment.
I like the reference but it feels out of place right here. Would it make more sense to place it above line 25?
3 participants
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Closes #6016
Closes #7362
Adds a new "Stale Flag Detection" page under Managing Flags covering what makes a feature stale, the plan and Feature Versioning requirements, how to configure the threshold, and how to exclude flags via a permanent tag. Cross-links added from Flag Lifecycle, Tagging, and Code References.
How did you test this code?
Ran
npx prettier --checkon the touched files. Cross-checked every claim on the page against the code inflagsmith-private/src/workflows_logic/stale_flags/.