Fix depth-stencil image aspect masks - #440
Open
swayam8624 wants to merge 2 commits into
Open
Conversation
swayam8624
marked this pull request as ready for review
July 29, 2026 05:50
asuessenbach
left a comment
Contributor
There was a problem hiding this comment.
An important fix.
Just one issue:
| { | ||
| vk::Format depthFormat = findDepthFormat(); | ||
| depthImageAspect = vk::ImageAspectFlagBits::eDepth; | ||
| if (hasStencilComponent(depthFormat)) |
Contributor
There was a problem hiding this comment.
Instead of the potentially being removed Renderer::hasStencilComponent (see #427), you might use the more general vk::hasStencilComponent from vulkan_format_traits.hpp.
Author
|
Addressed in commit f2b8e25. I added the explicit |
asuessenbach
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The tutorial can select a depth/stencil format such as VK_FORMAT_D32_SFLOAT_S8_UINT, while the attachment sample hardcodes VK_IMAGE_ASPECT_DEPTH_BIT. Validation then reports VUID-VkImageMemoryBarrier2-image-03320 because the stencil aspect is omitted.
Validation
cmake -S attachments -B build/tutorial -G Ninja -DCMAKE_BUILD_TYPE=Debug -DCMAKE_OSX_ARCHITECTURES=arm64 -DENABLE_CPP20_MODULE=OFF -DKTX_INCLUDE_DIR=... -DKTX_LIBRARY=...cmake --build build/tutorial --target 32_ecosystem_utilities -j4git diff --checkpassedThe executable initializes Vulkan but exits in this checkout because the required tutorial asset file is not found from the build layout.