Fix ClassCastException when allOf array changes to type array#916
Open
kamilkrzywanski wants to merge 2 commits into
Open
Fix ClassCastException when allOf array changes to type array#916kamilkrzywanski wants to merge 2 commits into
kamilkrzywanski wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
All reported issues were addressed across 5 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Assert the allOf-array and direct-array specs compare equal instead of only checking isCompatible(), which is also true for no changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #887
When a property changes from
allOfwrapping an array schema to a directtype: array, the left side stays aComposedSchemaafter resolution while the right side is anArraySchema. Casting both toArraySchemathrewClassCastException.Changes:
itemswhen merging composed schemas inaddSchemaSchema#getItems()inArraySchemaDiffResultinstead of castingSummary by cubic
Fixes a crash when diffing array schemas that change from an
allOf-wrapped array to a directtype: array. Prevents ClassCastException and ensures the specs compare equal.itemsinaddSchemawhen merging composed schemas.Schema#getItems()inArraySchemaDiffResultinstead of casting.Written for commit 99b2f79. Summary will update on new commits.