Skip to content

refactor: Do not emit any warnings in tests and treat warnings in tests as errors #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Moritz Potthoff (MoritzPotthoffQC) merged 3 commits into from
Jul 28, 2026
+24 −12
Merged

refactor: Do not emit any warnings in tests and treat warnings in tests as errors #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5790adc
fix
MoritzPotthoffQC Jul 28, 2026
eafb75c
fix
MoritzPotthoffQC Jul 28, 2026
74bd653
fix
MoritzPotthoffQC Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions diffly/comparison.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1246,9 +1246,12 @@ def _list_length_exprs(
"""Collect max-list-length scalar expressions for every List level in the type
tree."""
if isinstance(dtype, pl.List):
return [expr.list.len().max(), *_list_length_exprs(expr.explode(), dtype.inner)]
return [
expr.list.len().max(),
*_list_length_exprs(expr.explode(empty_as_null=True), dtype.inner),
]
if isinstance(dtype, pl.Array):
return _list_length_exprs(expr.explode(), dtype.inner)
return _list_length_exprs(expr.explode(empty_as_null=True), dtype.inner)
if isinstance(dtype, pl.Struct):
return [
e
Expand Down
5 changes: 5 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,3 +96,8 @@ default.extend-ignore-re = [
addopts = "--import-mode=importlib -m 'not generate'"
markers = ["generate: mark a test function as generating fixture output."]
testpaths = ["tests"]
filterwarnings = [
"error",
# polars' deprecation warning for horizontal concatenation cannot be solved, we are already using it correctly
"ignore:the default behavior of `how='horizontal'` for `concat` is deprecated:DeprecationWarning",
]
Comment thread
MoritzPotthoffQC marked this conversation as resolved.
24 changes: 14 additions & 10 deletions tests/test_fraction_same.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,20 +30,24 @@ def test_missing_primary_key_fraction_same() -> None:
@pytest.mark.parametrize("frame_type", FRAME_TYPES)
@pytest.mark.parametrize(
"dtypes_left",
itertools.zip_longest(
FLOAT_DTYPES,
SIGNED_INTEGER_DTYPES,
UNSIGNED_INTEGER_DTYPES,
fillvalue=pl.Float32,
list(
itertools.zip_longest(
FLOAT_DTYPES,
SIGNED_INTEGER_DTYPES,
UNSIGNED_INTEGER_DTYPES,
fillvalue=pl.Float32,
)
),
)
@pytest.mark.parametrize(
"dtypes_right",
itertools.zip_longest(
FLOAT_DTYPES,
SIGNED_INTEGER_DTYPES,
UNSIGNED_INTEGER_DTYPES,
fillvalue=pl.Float32,
list(
itertools.zip_longest(
FLOAT_DTYPES,
SIGNED_INTEGER_DTYPES,
UNSIGNED_INTEGER_DTYPES,
fillvalue=pl.Float32,
)
),
)
@pytest.mark.parametrize("parallel", [True, False])
Expand Down