feat: Respect show_perfect_column_matches for data inspection section - #51
Draft
Moritz Potthoff (MoritzPotthoffQC) wants to merge 1 commit into
Draft
feat: Respect show_perfect_column_matches for data inspection section#51Moritz Potthoff (MoritzPotthoffQC) wants to merge 1 commit into
show_perfect_column_matches for data inspection section#51Moritz Potthoff (MoritzPotthoffQC) wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #51 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 13
Lines 1140 1146 +6
=========================================
+ Hits 1140 1146 +6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Copilot started reviewing on behalf of
Moritz Potthoff (MoritzPotthoffQC)
July 28, 2026 21:53
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Diffly’s summary generation so show_perfect_column_matches=False also suppresses “Data Inspection” columns whose data metrics are identical between left/right, and refreshes the corresponding golden summary fixtures.
Changes:
- Pass
show_perfect_column_matchesinto_compute_data_inspection()and filter out columns with unchanged data metrics when disabled. - Clarify
DataFrameComparison.summary()docs to state the option also affects the “Data Inspection” section. - Regenerate multiple summary fixture outputs to reflect the new filtering behavior.
Reviewed changes
Copilot reviewed 34 out of 34 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| diffly/summary.py | Apply show_perfect_column_matches filtering to the Data Inspection section. |
| diffly/comparison.py | Document that show_perfect_column_matches also affects Data Inspection output. |
| tests/summary/fixtures/metrics_presets_many/gen/pretty_True_perfect_False_top_True_slim_True_sample_rows_True_sample_pk_True.txt | Update expected summary output fixture (omit perfect Data Inspection columns). |
| tests/summary/fixtures/metrics_presets_many/gen/pretty_True_perfect_False_top_True_slim_True_sample_rows_False_sample_pk_False.txt | Update expected summary output fixture (omit perfect Data Inspection columns). |
| tests/summary/fixtures/metrics_presets_many/gen/pretty_True_perfect_False_top_True_slim_False_sample_rows_True_sample_pk_True.txt | Update expected summary output fixture (omit perfect Data Inspection columns). |
| tests/summary/fixtures/metrics_presets_many/gen/pretty_True_perfect_False_top_True_slim_False_sample_rows_False_sample_pk_False.txt | Update expected summary output fixture (omit perfect Data Inspection columns). |
| tests/summary/fixtures/metrics_presets_many/gen/pretty_True_perfect_False_top_False_slim_True_sample_rows_True_sample_pk_False.txt | Update expected summary output fixture (omit perfect Data Inspection columns). |
| tests/summary/fixtures/metrics_presets_many/gen/pretty_True_perfect_False_top_False_slim_True_sample_rows_False_sample_pk_False.txt | Update expected summary output fixture (omit perfect Data Inspection columns). |
| tests/summary/fixtures/metrics_presets_many/gen/pretty_True_perfect_False_top_False_slim_False_sample_rows_True_sample_pk_False.txt | Update expected summary output fixture (omit perfect Data Inspection columns). |
| tests/summary/fixtures/metrics_presets_many/gen/pretty_True_perfect_False_top_False_slim_False_sample_rows_False_sample_pk_False.txt | Update expected summary output fixture (omit perfect Data Inspection columns). |
| tests/summary/fixtures/metrics_presets_many/gen/pretty_False_perfect_False_top_True_slim_True_sample_rows_True_sample_pk_True.txt | Update expected summary output fixture (omit perfect Data Inspection columns). |
| tests/summary/fixtures/metrics_presets_many/gen/pretty_False_perfect_False_top_True_slim_True_sample_rows_False_sample_pk_False.txt | Update expected summary output fixture (omit perfect Data Inspection columns). |
| tests/summary/fixtures/metrics_presets_many/gen/pretty_False_perfect_False_top_True_slim_False_sample_rows_True_sample_pk_True.txt | Update expected summary output fixture (omit perfect Data Inspection columns). |
| tests/summary/fixtures/metrics_presets_many/gen/pretty_False_perfect_False_top_True_slim_False_sample_rows_False_sample_pk_False.txt | Update expected summary output fixture (omit perfect Data Inspection columns). |
| tests/summary/fixtures/metrics_presets_many/gen/pretty_False_perfect_False_top_False_slim_True_sample_rows_True_sample_pk_False.txt | Update expected summary output fixture (omit perfect Data Inspection columns). |
| tests/summary/fixtures/metrics_presets_many/gen/pretty_False_perfect_False_top_False_slim_True_sample_rows_False_sample_pk_False.txt | Update expected summary output fixture (omit perfect Data Inspection columns). |
| tests/summary/fixtures/metrics_presets_many/gen/pretty_False_perfect_False_top_False_slim_False_sample_rows_True_sample_pk_False.txt | Update expected summary output fixture (omit perfect Data Inspection columns). |
| tests/summary/fixtures/metrics_presets_many/gen/pretty_False_perfect_False_top_False_slim_False_sample_rows_False_sample_pk_False.txt | Update expected summary output fixture (omit perfect Data Inspection columns). |
| tests/summary/fixtures/metrics_data_no_pk/gen/pretty_True_perfect_False_top_True_slim_True_sample_rows_True_sample_pk_True.txt | Update expected summary output fixture (omit perfect Data Inspection columns). |
| tests/summary/fixtures/metrics_data_no_pk/gen/pretty_True_perfect_False_top_True_slim_True_sample_rows_False_sample_pk_False.txt | Update expected summary output fixture (omit perfect Data Inspection columns). |
| tests/summary/fixtures/metrics_data_no_pk/gen/pretty_True_perfect_False_top_True_slim_False_sample_rows_True_sample_pk_True.txt | Update expected summary output fixture (omit perfect Data Inspection columns). |
| tests/summary/fixtures/metrics_data_no_pk/gen/pretty_True_perfect_False_top_True_slim_False_sample_rows_False_sample_pk_False.txt | Update expected summary output fixture (omit perfect Data Inspection columns). |
| tests/summary/fixtures/metrics_data_no_pk/gen/pretty_True_perfect_False_top_False_slim_True_sample_rows_True_sample_pk_False.txt | Update expected summary output fixture (omit perfect Data Inspection columns). |
| tests/summary/fixtures/metrics_data_no_pk/gen/pretty_True_perfect_False_top_False_slim_True_sample_rows_False_sample_pk_False.txt | Update expected summary output fixture (omit perfect Data Inspection columns). |
| tests/summary/fixtures/metrics_data_no_pk/gen/pretty_True_perfect_False_top_False_slim_False_sample_rows_True_sample_pk_False.txt | Update expected summary output fixture (omit perfect Data Inspection columns). |
| tests/summary/fixtures/metrics_data_no_pk/gen/pretty_True_perfect_False_top_False_slim_False_sample_rows_False_sample_pk_False.txt | Update expected summary output fixture (omit perfect Data Inspection columns). |
| tests/summary/fixtures/metrics_data_no_pk/gen/pretty_False_perfect_False_top_True_slim_True_sample_rows_True_sample_pk_True.txt | Update expected summary output fixture (omit perfect Data Inspection columns). |
| tests/summary/fixtures/metrics_data_no_pk/gen/pretty_False_perfect_False_top_True_slim_True_sample_rows_False_sample_pk_False.txt | Update expected summary output fixture (omit perfect Data Inspection columns). |
| tests/summary/fixtures/metrics_data_no_pk/gen/pretty_False_perfect_False_top_True_slim_False_sample_rows_True_sample_pk_True.txt | Update expected summary output fixture (omit perfect Data Inspection columns). |
| tests/summary/fixtures/metrics_data_no_pk/gen/pretty_False_perfect_False_top_True_slim_False_sample_rows_False_sample_pk_False.txt | Update expected summary output fixture (omit perfect Data Inspection columns). |
| tests/summary/fixtures/metrics_data_no_pk/gen/pretty_False_perfect_False_top_False_slim_True_sample_rows_True_sample_pk_False.txt | Update expected summary output fixture (omit perfect Data Inspection columns). |
| tests/summary/fixtures/metrics_data_no_pk/gen/pretty_False_perfect_False_top_False_slim_True_sample_rows_False_sample_pk_False.txt | Update expected summary output fixture (omit perfect Data Inspection columns). |
| tests/summary/fixtures/metrics_data_no_pk/gen/pretty_False_perfect_False_top_False_slim_False_sample_rows_True_sample_pk_False.txt | Update expected summary output fixture (omit perfect Data Inspection columns). |
| tests/summary/fixtures/metrics_data_no_pk/gen/pretty_False_perfect_False_top_False_slim_False_sample_rows_False_sample_pk_False.txt | Update expected summary output fixture (omit perfect Data Inspection columns). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1156
to
+1162
| columns = [] | ||
| for col_name in sorted(data_metrics_by_column): | ||
| results = data_metrics_by_column[col_name] | ||
| if not show_perfect_column_matches and all( | ||
| r.left == r.right for r in results.values() | ||
| ): | ||
| continue |
Contributor
Author
There was a problem hiding this comment.
irrelevant
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Changes