Add HandlerError::from_boxed#301
Merged
Merged
Conversation
Member
|
Good points, thank you for the PR! 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found there was no easy way to create a
HandlerErrorfrom an already boxed error.Until Rust gets negative traits, we can't have an
impl From<Box<dyn Error>> for HandlerErrorimplementation. So for now I just added afrom_boxedmethod.There were also a couple of places with unecessary
'staticlabels (Boxalready implies that the contents are'static), so I removed them.