Fix duplicated package manager issue with create-test-app script - #8178
Open
lusarz wants to merge 1 commit into
Open
Fix duplicated package manager issue with create-test-app script#8178lusarz wants to merge 1 commit into
lusarz wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
./bin/create-test-app.jsfails withFlag --package-manager can only be specified onceon every local run.The root
create-appscript inpackage.jsonwas changed in #7254 to hardcode--package-manager pnpm:create-test-app.jsalso appended its own--package-manager=${nodePackageManager}flag when building the local install args, so the underlyingapp:initcommand ended up receiving--package-managertwice, which oclif rejects.WHAT is this pull request doing?
Removes the redundant
--package-managerflag thatcreate-test-app.jswas appending for local installs, since the rootcreate-appscript already supplies it.How to test your changes?
Should complete without the
Flag --package-manager can only be specified onceerror.Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add