[Refactor] Extract parseEnvNumber helper in environment.ts - #8179
[Refactor] Extract parseEnvNumber helper in environment.ts#8179gonzaloriestra wants to merge 1 commit into
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Merge activity
|
WHY are these changes introduced?
To improve codebase readability, maintainability, and reduce code duplication by extracting shared number-parsing environment variable logic in
packages/cli-kit/src/public/node/environment.ts.WHAT is this pull request doing?
Extracted a private
parseEnvNumberhelper function inpackages/cli-kit/src/public/node/environment.tswhich deduplicates number-parsing logic insidegetBackendPortandmaxRequestTimeForNetworkCallsMs. Added corresponding unit tests inpackages/cli-kit/src/public/node/environment.test.ts.How to test your changes?
CI
Post-release steps
None
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset addPR created automatically by Jules for task 1503683400826785224 started by @gonzaloriestra