perf(datagrid): bound cache work to visible columns#1964
Draft
andiahmads wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The display cache allocated space for every result column when the first cell in a row was formatted. Its synchronous and background prewarm paths also formatted every column in each row. A 1,000-row result with 500 columns could therefore schedule 500,000 formatting operations on the main actor, including cells far outside the viewport.
Cache cost updates also rescanned the dense row storage after each formatted cell. This made on-demand rendering scale with the total schema width instead of the number of visible cells.
Impact
Wide ClickHouse results now keep prewarm and cache work bounded to the visible columns. Horizontal scrolling fills newly visible columns on demand and then prewarms those columns after live scrolling ends.
Fixes #1219
Validation
swiftlint lint --strictgit diff --checkxcodebuild -project TablePro.xcodeproj -scheme TablePro -destination 'platform=macOS,arch=arm64' -skipPackagePluginValidation CODE_SIGNING_ALLOWED=NO test -only-testing:TableProTests/RowDisplayCacheTests -only-testing:TableProTests/TableViewCoordinatorDisplayCacheTestsTableProTestsrun: 8,631 passed and 77 unrelated tests failed in the local environment. The changed DataGrid and cache suites passed.