Skip to content

docs(philosophy): clarify 'Three.js framework adapters' to 'Three.js renderers' - #2251

Open
kushaim wants to merge 1 commit into
TanStack:mainfrom
kushaim:docs/philosophy-clarify-three-js
Open

docs(philosophy): clarify 'Three.js framework adapters' to 'Three.js renderers'#2251
kushaim wants to merge 1 commit into
TanStack:mainfrom
kushaim:docs/philosophy-clarify-three-js

Conversation

@kushaim

@kushaim kushaim commented Jul 21, 2026

Copy link
Copy Markdown

Three.js framework adapters → Three.js renderers. Three.js is a WebGL renderer, not a framework, and the surrounding sentence uses
enderer for everything else.

…renderers'

In the 'Controlled is Cool' section, the bullet on Non-DOM support said
'Three.js framework adapters'. Three.js is not a framework - it's a
WebGL rendering library. The intended meaning was that TanStack Form's
controlled-component approach works with non-DOM renderers, including
Three.js. Replaced 'framework adapters' with 'renderers' to be accurate.
Copilot AI review requested due to automatic review settings July 21, 2026 23:05
@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The philosophy documentation rewords the “Non-DOM support” bullet to describe Three.js renderers instead of Three.js framework adapters.

Changes

Documentation update

Layer / File(s) Summary
Non-DOM support terminology
docs/philosophy.md
The Three.js example is reworded from “framework adapters” to “renderers.”

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: copilot

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is too brief and missing the required Changes, Checklist, and Release Impact sections. Fill in the template with a Changes summary, the checklist items, and the Release Impact selection.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly summarizes the docs-only wording change from framework adapters to renderers.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Clarifies documentation wording in the “Controlled is Cool” section to more accurately describe Three.js usage as a renderer context (non-DOM render targets), aligning the phrasing with Three.js’s role as a rendering library.

Changes:

  • Replaced “Three.js framework adapters” with “Three.js renderers” in the Non-DOM support bullet.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants