Skip to content

fix(semantic-layers): show a friendly warning when schema enrichment falls back#42400

Open
rusackas wants to merge 1 commit into
masterfrom
fix/semantic-layer-fallback-warning
Open

fix(semantic-layers): show a friendly warning when schema enrichment falls back#42400
rusackas wants to merge 1 commit into
masterfrom
fix/semantic-layer-fallback-warning

Conversation

@rusackas

Copy link
Copy Markdown
Member

SUMMARY

When configuration-schema enrichment fails (connection refused, driver hiccups, etc.), the raw exception text was passed through to the UI as a danger toast. That reads as raw internals, varies wildly by driver, and isn't translatable. This swaps it for a stable, translatable message pointing at the server logs, where the full exception is already recorded via logger.exception.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before: toast shows e.g. connection failed (whatever the driver raised).
After: toast shows "Could not load metadata for this configuration; showing the default form. See the server logs for details."

TESTING INSTRUCTIONS

pytest tests/unit_tests/semantic_layers/api_test.py

Or point a semantic layer config at an unreachable host in the modal and confirm the toast shows the new message while the fallback form still renders.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

🤖 Generated with Claude Code

…falls back

Enrichment failures (connection refused, driver quirks, etc.) were
toasted to the user verbatim, which reads as raw internals and varies
by driver. Replace it with a stable, translatable message pointing at
the server logs, where the full exception is already recorded.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@rusackas
rusackas requested review from sadpandajoe and sha174n July 24, 2026 20:43
@dosubot dosubot Bot added the i18n:general Related to translations label Jul 24, 2026
@bito-code-review

bito-code-review Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Code Review Agent Run #be2ba4

Actionable Suggestions - 0
Review Details
  • Files reviewed - 2 · Commit Range: 1a16b2a..1a16b2a
    • superset/semantic_layers/api.py
    • tests/unit_tests/semantic_layers/api_test.py
  • Files skipped - 0
  • Tools
    • MyPy (Static Code Analysis) - ✔︎ Successful
    • Astral Ruff (Static Code Analysis) - ✔︎ Successful
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

@github-actions github-actions Bot added the api Related to the REST API label Jul 24, 2026
@codecov

codecov Bot commented Jul 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.27%. Comparing base (5ffdac1) to head (1a16b2a).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #42400   +/-   ##
=======================================
  Coverage   65.27%   65.27%           
=======================================
  Files        2795     2795           
  Lines      157549   157549           
  Branches    36039    36039           
=======================================
  Hits       102836   102836           
  Misses      52736    52736           
  Partials     1977     1977           
Flag Coverage Δ
hive 38.43% <0.00%> (ø)
mysql 57.63% <0.00%> (ø)
postgres 57.67% <0.00%> (ø)
presto 40.35% <0.00%> (ø)
python 59.08% <100.00%> (ø)
sqlite 57.30% <0.00%> (ø)
unit 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Related to the REST API i18n:general Related to translations size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant