fix(semantic-layers): show a friendly warning when schema enrichment falls back#42400
fix(semantic-layers): show a friendly warning when schema enrichment falls back#42400rusackas wants to merge 1 commit into
Conversation
…falls back Enrichment failures (connection refused, driver quirks, etc.) were toasted to the user verbatim, which reads as raw internals and varies by driver. Replace it with a stable, translatable message pointing at the server logs, where the full exception is already recorded. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Code Review Agent Run #be2ba4Actionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #42400 +/- ##
=======================================
Coverage 65.27% 65.27%
=======================================
Files 2795 2795
Lines 157549 157549
Branches 36039 36039
=======================================
Hits 102836 102836
Misses 52736 52736
Partials 1977 1977
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
SUMMARY
When configuration-schema enrichment fails (connection refused, driver hiccups, etc.), the raw exception text was passed through to the UI as a danger toast. That reads as raw internals, varies wildly by driver, and isn't translatable. This swaps it for a stable, translatable message pointing at the server logs, where the full exception is already recorded via
logger.exception.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before: toast shows e.g.
connection failed(whatever the driver raised).After: toast shows "Could not load metadata for this configuration; showing the default form. See the server logs for details."
TESTING INSTRUCTIONS
Or point a semantic layer config at an unreachable host in the modal and confirm the toast shows the new message while the fallback form still renders.
ADDITIONAL INFORMATION
🤖 Generated with Claude Code