feat(dataset): add contributor metadata storage and API - #6952
Open
xuang7 wants to merge 1 commit into
Open
Conversation
Add a dataset_contributor table (name, creator flag, email, affiliation,
comments) with cascade delete, expose contributors on the dataset detail
response, accept them at dataset creation, and add a write-guarded
POST /dataset/{did}/update/contributors endpoint that replaces the list.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
github-actions
Bot
added
feature
ddl-change
Contributor
Automated Reviewer SuggestionsBased on the
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6952 +/- ##
============================================
- Coverage 78.93% 78.93% -0.01%
Complexity 3784 3784
============================================
Files 1160 1160
Lines 46049 46047 -2
Branches 5110 5110
============================================
- Hits 36350 36348 -2
Misses 8078 8078
Partials 1621 1621
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
| config | throughput | MB/s | latency | max Δ latest / 7d | |
|---|---|---|---|---|---|
| 🔴 | bs=10 sw=10 sl=64 | 383 | 0.234 | 25,567/33,728/33,728 us | 🔴 +21.5% / 🔴 +107.8% |
| 🟢 | bs=100 sw=10 sl=64 | 833 | 0.508 | 118,235/133,709/133,709 us | 🟢 -11.5% / 🔴 +23.1% |
| ⚪ | bs=1000 sw=10 sl=64 | 953 | 0.582 | 1,050,028/1,088,475/1,088,475 us | ⚪ within ±5% / 🔴 -5.1% |
Baseline details
Latest main 31f1e7b from same runner
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---|---|---|---|---|
| bs=10 sw=10 sl=64 | throughput | 383 tuples/sec | 457 tuples/sec | 767.9 tuples/sec | -16.2% | -50.1% |
| bs=10 sw=10 sl=64 | MB/s | 0.234 MB/s | 0.279 MB/s | 0.469 MB/s | -16.1% | -50.1% |
| bs=10 sw=10 sl=64 | p50 | 25,567 us | 21,330 us | 12,502 us | +19.9% | +104.5% |
| bs=10 sw=10 sl=64 | p95 | 33,728 us | 27,764 us | 16,234 us | +21.5% | +107.8% |
| bs=10 sw=10 sl=64 | p99 | 33,728 us | 27,764 us | 18,919 us | +21.5% | +78.3% |
| bs=100 sw=10 sl=64 | throughput | 833 tuples/sec | 836 tuples/sec | 974.8 tuples/sec | -0.4% | -14.5% |
| bs=100 sw=10 sl=64 | MB/s | 0.508 MB/s | 0.51 MB/s | 0.595 MB/s | -0.4% | -14.6% |
| bs=100 sw=10 sl=64 | p50 | 118,235 us | 116,762 us | 102,449 us | +1.3% | +15.4% |
| bs=100 sw=10 sl=64 | p95 | 133,709 us | 151,101 us | 108,652 us | -11.5% | +23.1% |
| bs=100 sw=10 sl=64 | p99 | 133,709 us | 151,101 us | 116,310 us | -11.5% | +15.0% |
| bs=1000 sw=10 sl=64 | throughput | 953 tuples/sec | 956 tuples/sec | 1,004 tuples/sec | -0.3% | -5.1% |
| bs=1000 sw=10 sl=64 | MB/s | 0.582 MB/s | 0.583 MB/s | 0.613 MB/s | -0.2% | -5.0% |
| bs=1000 sw=10 sl=64 | p50 | 1,050,028 us | 1,044,502 us | 999,606 us | +0.5% | +5.0% |
| bs=1000 sw=10 sl=64 | p95 | 1,088,475 us | 1,095,818 us | 1,046,770 us | -0.7% | +4.0% |
| bs=1000 sw=10 sl=64 | p99 | 1,088,475 us | 1,095,818 us | 1,076,937 us | -0.7% | +1.1% |
Raw CSV
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,522.35,200,128000,383,0.234,25566.56,33727.71,33727.71
1,100,10,64,20,2402.14,2000,1280000,833,0.508,118234.85,133709.45,133709.45
2,1000,10,64,20,20979.01,20000,12800000,953,0.582,1050028.12,1088474.63,1088474.63
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends Texera’s dataset metadata support by introducing first-class dataset contributor records in the database and exposing them through the file-service dataset APIs, enabling proper attribution beyond the dataset owner.
Changes:
- Adds a new
dataset_contributortable via DDL + incremental migration and registers it in the SQL changelog. - Extends
file-servicedataset creation/detail responses to persist and return contributor metadata. - Introduces a new endpoint to replace a dataset’s contributor list, with ScalaTest coverage for persistence, replacement, validation, and cascade deletion.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
sql/updates/29.sql |
Adds incremental migration for the new dataset_contributor table. |
sql/texera_ddl.sql |
Updates baseline schema to include dataset_contributor. |
sql/changelog.xml |
Registers migration 29 in the changelog. |
file-service/src/main/scala/org/apache/texera/service/resource/DatasetResource.scala |
Implements contributor persistence/retrieval + new update endpoint. |
file-service/src/test/scala/org/apache/texera/service/resource/DatasetResourceSpec.scala |
Adds tests covering contributor lifecycle, validation, permissions, and cascade behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+230
to
+236
| case class Contributor( | ||
| name: String, | ||
| creator: Boolean = false, | ||
| affiliation: String, | ||
| email: String, | ||
| comments: String | ||
| ) |
Comment on lines
+30
to
+35
| name VARCHAR(256) NOT NULL, | ||
| creator BOOLEAN NOT NULL DEFAULT FALSE, | ||
| email VARCHAR(256), | ||
| affiliation VARCHAR(256), | ||
| comments TEXT, | ||
| FOREIGN KEY (did) REFERENCES dataset(did) ON DELETE CASCADE |
Comment on lines
+567
to
+576
| @POST | ||
| @Consumes(Array(MediaType.APPLICATION_JSON)) | ||
| @Produces(Array(MediaType.APPLICATION_JSON)) | ||
| @RolesAllowed(Array("REGULAR", "ADMIN")) | ||
| @Path("/{did}/update/contributors") | ||
| def updateDatasetContributors( | ||
| @PathParam("did") did: Integer, | ||
| modificator: DatasetContributorsModification, | ||
| @Auth user: SessionUser | ||
| ): Response = { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
This PR adds contributor metadata to datasets so that dataset authors and other contributors can be properly acknowledged. Each dataset can record a list of contributors, where each contributor has a name, a creator flag, an email address, an affiliation, and a free-text comments field.
Changes:
dataset_contributortable with a foreign key todatasetand cascade deletion intexera_ddl.sql, along with the incremental migration scriptsql/updates/29.sqland changelog entry 29.file-serviceso that contributors are:POST /dataset/{did}/update/contributorsendpoint protected by the existing WRITE-access check.Currently, contributors are stored independently for each dataset. Cross-dataset contributor identity is left as a future extension. The UI will be added in a follow-up PR.
Any related issues, documentation, discussions?
Related to #6926
How was this PR tested?
7 ScalaTest cases were added.
Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Fable 5)