Add a new function DeleteOnOrig - #256
Closed
crowfrog wants to merge 2 commits into
Closed
Conversation
Author
securityguy
added a commit
to securityguy/jsonparser
that referenced
this pull request
Mar 18, 2026
…nhancements Module renamed from github.com/buger/jsonparser to github.com/securityguy/jsonparser. Security fixes: - Fix GO-2026-4514: Delete() panics on malformed JSON (negative slice index DoS) - Update Dockerfile base image from golang:1.6 to golang:1.21 Bug fixes: - Fix EachKey failing to extract values from arrays of strings (PR buger#180) - Remove duplicate import in parser_test.go (PR buger#263) New APIs (all additive): - ArrayEach callback now accepts *error for early termination; DoneError sentinel added (PR buger#134) - DeleteOnOrig: in-place deletion variant with no allocation (PR buger#256) - ArrayIterator: lazy closure-based array iteration (PR buger#254) - GetRaw, EachRawKey: raw JSON byte extraction without type parsing (PR buger#250) Other: - go.mod bumped to go 1.18 - benchmark/go.mod updated with replace directive pointing to local module - CLAUDE.md added for Claude Code guidance Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Owner
|
Closing — this PR's |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: add a new function DeleteOnOrig which can do delete operation on original slice. It will really help improve performance by reducing one memory alloc/dealloc and one whole copy per one call.
Benchmark before change:
Benchmark after change:
These is no benchmark case because no new code introduced almost.