Adjust IsReadable() for Termux environment without pthread_cancel() - #6249
Open
craigcomstock wants to merge 5 commits into
Open
Adjust IsReadable() for Termux environment without pthread_cancel()#6249craigcomstock wants to merge 5 commits into
craigcomstock wants to merge 5 commits into
Conversation
Contributor
Author
|
Wanted to post this PR to get github's opinion on the changes. The commits have been in the works for a long time and need to be adjusted as they include gradual changes and improvements that should be collected into fewer commits. Will do soon. |
craigcomstock
force-pushed
the
CFE-4401-2/master
branch
from
July 28, 2026 21:03
fe0e8dd to
6061785
Compare
craigcomstock
marked this pull request as ready for review
July 29, 2026 13:41
Contributor
Author
they have been reworked. ready to go. |
Ticket: none Changelog: none
Ticket: none Changelog: none
craigcomstock
force-pushed
the
CFE-4401-2/master
branch
from
July 29, 2026 20:37
b49fe9e to
1ac7e4c
Compare
instead use MaskTerminationSignalsInThread() from libntech Ticket: CFE-4401 Changelog: title
AC_CHECK_FUNCS apparently doesn't take into account the __ANDROID_API__ level properly and so incorrectly determines that copy_file_range is available for termux at API 24 but copy_file_range is <= 34. Ticket: none Changelog: none
The re-entrant versions of srand() and friends aren't technically required and not using them enables compilation on platforms without glibc. Ticket: none Changelog: none
craigcomstock
force-pushed
the
CFE-4401-2/master
branch
from
July 29, 2026 20:39
1ac7e4c to
3d3d2e1
Compare
larsewi
approved these changes
Jul 30, 2026
Member
|
@cf-bottom jenkins, please |
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/14370/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-14370/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.