ENT-14326: Various fixes to the Ansible promise type - #153
Open
larsewi wants to merge 5 commits into
Open
Conversation
larsewi
commented
Jul 30, 2026
larsewi
commented
Contributor
- Narrow ansible ModuleNotFoundError guard to the imports
- Install ansible callback so it survives ansible-core 2.19
- Read the ansible playbook attribute from the attribute model
- Apply the ansible limit attribute
- Stop reporting skipped ansible tasks as errors
Ticket: ENT-14326 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
TaskQueueManager stopped accepting the stdout callback as an object, so ansible loaded its default one instead and printed the play output onto stdout, corrupting the promise module protocol. Ticket: ENT-14326 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
It was read from the raw request dict, so the documented "fallback to the promiser" never applied and omitting the attribute raised a KeyError. Ticket: ENT-14326 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
It was declared and documented, but never read, so setting it did nothing. For backwards compatibility, default to no limit rather than the documented localhost, which would have restricted every existing promise to the local host. Ticket: ENT-14326 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
A task is skipped when its condition does not match, which means nothing failed. Log it at the same level as a task that ran without changing anything. Ticket: ENT-14326 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.