-
Notifications
You must be signed in to change notification settings - Fork 461
feat(ui): Support signUpIfMissing with Clerk <SignIn> component #7928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dmoerner
wants to merge
23
commits into
main
Choose a base branch
from
daniel/user-4769-sign-up-if-missing-clerk-components
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
84d79f6
feat(ui): Support signUpIfMissing with Clerk <SignIn> component
dmoerner bc2274f
Merge branch 'main' into daniel/user-4769-sign-up-if-missing-clerk-co…
dmoerner 721b518
Merge branch 'main' into daniel/user-4769-sign-up-if-missing-clerk-co…
dmoerner 40d8ceb
fix: Also add transferable status to SignInFuture email link
dmoerner 45b2b6d
Merge branch 'main' into daniel/user-4769-sign-up-if-missing-clerk-co…
dmoerner 16207c3
fix: Explicitly guard restricted modes and username sign in
dmoerner c84148b
fix: Improve error handling in transfer flow
dmoerner 7a4025b
fix: Align sign up if missing with oauth transfer navigation
dmoerner 34c36bb
fix: Correct imports and function type
dmoerner 5a674b8
fix: Revert unnecessary addition of transferable to email link errors
dmoerner 01bc760
fix: Better document the literal type for email link status
dmoerner 41c12ba
fix: import ordering
dmoerner f88900e
Merge branch 'main' into daniel/user-4769-sign-up-if-missing-clerk-co…
dmoerner a3d6e9b
chore: Update changeset
dmoerner 625bdc2
fix(*): Address review feedback on sign-up-if-missing transfer
dmoerner 77325fd
fix(ui): Distinct copy for transferable email-link verification
dmoerner 99e9770
Merge branch 'main' into daniel/user-4769-sign-up-if-missing-clerk-co…
wobsoriano c317949
Merge branch 'main' into daniel/user-4769-sign-up-if-missing-clerk-co…
wobsoriano 76c067e
chore: bundlewatch fix
wobsoriano 2723ff0
fix(ui): Guard attackProtection read against clerk-js version skew
dmoerner a505f95
test(ui): Mock the real FAPI error code for sign-up-if-missing transfers
dmoerner ec83f7c
fix(ui): Let whichever tab owns the sign-in perform the sign-up transfer
dmoerner 1cbe26e
feat(ui): Warn when password and enumeration protection strand sign-i…
dmoerner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| --- | ||
| '@clerk/clerk-js': minor | ||
| '@clerk/shared': minor | ||
| '@clerk/ui': minor | ||
| '@clerk/localizations': minor | ||
| --- | ||
|
|
||
| Support sign-in-or-sign-up combined flow with Clerk <SignIn> component | ||
| when strict enumeration protection is enabled. | ||
|
|
||
| On development instances, `<SignIn>` now logs a warning when the sign-in-or-up flow is rendered on an | ||
| instance that has both password and strict enumeration protection enabled. In that configuration | ||
| visitors without an account are routed to the password screen and cannot complete a sign-up, so the | ||
| warning names both settings and how to resolve them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since no session exists here yet, if the verification link replaces the polling tab or the original tab is gone, nothing runs the transfer and the user is told to return to a tab that no longer exists, correct? Should this branch complete the transfer on the current client and mirror the verified handling further down?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good point. I went back and forth here on how to handle the polling tab or the new tab. I'm going to switch to using the other tab. Currently re-running my E2E tests with this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in ec83f7c