CMake: migrate cuSolverMp feature definitions after #7671 - #7697
Merged
mohanchen merged 1 commit intoJul 29, 2026
Conversation
Author
|
|
Growl1234
approved these changes
Jul 27, 2026
AsTonyshment
approved these changes
Jul 29, 2026
mohanchen
approved these changes
Jul 29, 2026
Collaborator
|
Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reminder
AGENTS.mdanddocs/developers_guide/agent_governance.md.source/changes.Linked Issue
No separate issue is needed because this is a focused CMake regression introduced by #7671 with a known cause, a minimal fix, and before/after validation evidence.
Unit Tests and/or Case Tests for my changes
python3 tools/03_code_analysis/agent_governance_check.py --base upstream/develop --head HEAD --format text;git diff --check upstream/develop..HEAD; a repository search for staleabacus_add_feature_definitionscalls; and a stable patch-id comparison against validated commit320bf1709.320bf1709. Fork run 30249299891 configured, built, and installed ABACUS successfully with this patch and passed the 1-GPU, 2-GPU, and 4-GPU test groups.SetupCuSolverMp.cmakecalled the helper removed by CMake: Refactor feature build requirements into source/CMakeLists.txt #7671.cmakeis not installed in the local environment; the available Docker CLI cannot access the Docker daemon. The dependency-complete SAI run above provides the end-to-end configuration and build evidence.What's changed?
abacus_add_feature_definitionscalls from the cuSolverMp and cuBLASMp setup modules.__CUSOLVERMP,__CUBLASMP, and__USE_CALto the centralized feature-definition list introduced by CMake: Refactor feature build requirements into source/CMakeLists.txt #7671, preserving the original option and backend conditions.Governance Notes