Skip to content

feat: add link formatting to PDF converters#12095

Draft
zcxGGmu wants to merge 1 commit into
deepset-ai:mainfrom
zcxGGmu:fix/10677-pdf-link-format
Draft

feat: add link formatting to PDF converters#12095
zcxGGmu wants to merge 1 commit into
deepset-ai:mainfrom
zcxGGmu:fix/10677-pdf-link-format

Conversation

@zcxGGmu

@zcxGGmu zcxGGmu commented Jul 21, 2026

Copy link
Copy Markdown

Summary

  • Add link_format to PyPDFToDocument and PDFMinerToDocument with markdown, plain, and none modes.
  • Preserve default text-only extraction when link_format="none".
  • Add hyperlink PDF fixture coverage for PyPDF, PyPDF layout mode, and PDFMiner.
  • Document the new option and add a release note.

Fixes #10677

Testing

  • hatch -e test run pytest test/components/converters/test_pypdf_to_document.py test/components/converters/test_pdfminer_to_document.py
  • hatch -e test run mypy --python-version 3.13 --install-types --non-interactive --cache-dir=.mypy_cache/ haystack/components/converters/utils.py haystack/components/converters/pypdf.py haystack/components/converters/pdfminer.py
  • hatch run fmt-check haystack/components/converters/utils.py haystack/components/converters/pypdf.py haystack/components/converters/pdfminer.py test/components/converters/test_pypdf_to_document.py test/components/converters/test_pdfminer_to_document.py
  • git diff --check

@zcxGGmu
zcxGGmu requested a review from a team as a code owner July 21, 2026 10:46
@zcxGGmu
zcxGGmu requested review from sjrl and removed request for a team July 21, 2026 10:46
@HaystackBot

Copy link
Copy Markdown
Contributor

Hi @zcxGGmu, thanks a lot for your contribution! 🙏

We noticed that the Contributor License Agreement (CLA) check (license/cla) hasn't passed yet, so we've temporarily moved this PR to draft and paused the review assignment.

To get your PR reviewed, please sign the CLA via the link in the license/cla check below (or in the CLA bot comment). As soon as the check turns green, this PR will automatically be marked ready for review again and a reviewer will be re-assigned.

@HaystackBot
HaystackBot removed the request for review from sjrl July 21, 2026 11:56
@HaystackBot HaystackBot added the cla-pending PR is in draft until the contributor signs the CLA label Jul 21, 2026
@HaystackBot
HaystackBot marked this pull request as draft July 21, 2026 11:56
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-pending PR is in draft until the contributor signs the CLA topic:tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Add link_format parameter to PDFMinerToDocument and PyPDFToDocument

4 participants