Signal migration: CircularHeatmap, Settings, Mappings and Teams Components - #581
Merged
vbakke merged 3 commits intoJul 28, 2026
Merged
Conversation
- Convert 10 mutable properties to signal(), hasTeamsFilter to computed() - Replace ngOnInit/requestAnimationFrame with afterNextRender - Replace theme$ RxJS subscription with effect() - Dissolve destroy$/takeUntil in favor of DestroyRef - Fix order-sensitive group highlight (set-based comparison) - Fix group selection wipe (new object refs via .set()) - Prevent group chip deselection via per-chip selectionChange guard
- Convert allTeams, dataStore, searchTerms in MappingComponent to signal() - Convert meta, dataStoreMaxLevel, selectedMaxLevel, selectedMaxLevelCaption, editingProgressDefinitions, remoteReleaseCheck, selectedDateFormat in SettingsComponent to signal() - Refactor checkForLatestRelease to build state via local vars + single .set()/.update() instead of mutating remoteReleaseCheck fields directly - Remove unused GithubReleaseInfo import and dead checkingLatest/latestReleaseInfo/etc. fields - Convert dataStore, canEdit, teams, teamGroups, progressTitleImplemented, infoTitle, infoTeams, info, allColumnNames, progressColumnNames in TeamsComponent to signal() - Rework onSelectionChanged/onTeamsChanged to derive new info/currentInfo objects and .set() instead of mutating in place - Update mapping/settings/teams templates and specs to call signals as functions
…ping & Team Component to migration-doc
vbakke
approved these changes
Jul 28, 2026
vbakke
left a comment
vbakke
left a comment
Collaborator
There was a problem hiding this comment.
You said this PR was trivial, @sawankshrma , so I just visually browsed through it here. Looks okay, and I approve. :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
description in doc