test(terminal-report-filter): cover synthetic + replay report validators#293
Open
dormouse-bot wants to merge 1 commit into
Open
test(terminal-report-filter): cover synthetic + replay report validators#293dormouse-bot wants to merge 1 commit into
dormouse-bot wants to merge 1 commit into
Conversation
Deploying mouseterm with
|
| Latest commit: |
c681bec
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://edb4f4d3.mouseterm.pages.dev |
| Branch Preview URL: | https://nightly-report-filter-tests.mouseterm.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Surfaced by the nightly code-quality survey.
terminal-report-filter.tshad test coverage only forstripMouseReportsFromInput. Its two most complex exports —inputIsSyntheticTerminalReportandinputIsReplayTerminalReport— had none anywhere in the repo, despite being consumed by the replay/lifecycle path to decide whether inbound data is a synthetic terminal report that should be filtered rather than shown to the user.Both are tokenizer/validators built from concatenated CSI/SS3/OSC (and, for replay, DCS/focus) regexes with an all-chunks-must-validate rule. A regression in the token set or the
^(?:…)$anchoring — e.g. loosening the.fallback — could let real user input be misclassified as a synthetic report and silently dropped, with nothing to catch it.This PR adds tests pinning the current behavior:
\x1b[2J(clear screen).No production code changes — coverage only. All 11 tests in the file pass locally (
vitest run src/lib/terminal-report-filter.test.ts).