test(ecdsa): exercise the real trailing-bytes rejection branch#294
Open
dormouse-bot wants to merge 1 commit into
Open
test(ecdsa): exercise the real trailing-bytes rejection branch#294dormouse-bot wants to merge 1 commit into
dormouse-bot wants to merge 1 commit into
Conversation
Deploying mouseterm with
|
| Latest commit: |
c05abe0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://127bf7f6.mouseterm.pages.dev |
| Branch Preview URL: | https://nightly-ecdsa-trailing-bytes.mouseterm.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Surfaced by the nightly code-quality survey.
The
DER parsing rejects malformed inputtest intended to cover the trailing-bytes rejection inecdsaDerToRaw(invalid DER: trailing bytes), but it appended a byte outside the declared SEQUENCE length. That trips the earlieroffset + sequenceLength !== der.lengthguard (invalid DER: length mismatch) first, so the genuine trailing-bytes branch — extra bytes inside the declared SEQUENCE length, after both INTEGERs — was never exercised. The assertion only passed because it matched the broad/invalid DER/regex, so a regression in that branch would have gone undetected.This PR splits the case in two:
/length mismatch/, which is what it actually reaches./trailing bytes/branch.Test-only change. Full
server-lib-commonsuite passes locally (pnpm test→ 111 pass, 0 fail).