test(mouse-selection-keys): cover drag, copy, and non-terminal-yield branches#305
Open
dormouse-bot wants to merge 1 commit into
Open
test(mouse-selection-keys): cover drag, copy, and non-terminal-yield branches#305dormouse-bot wants to merge 1 commit into
dormouse-bot wants to merge 1 commit into
Conversation
Deploying mouseterm with
|
| Latest commit: |
8ce61a2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://54617a22.mouseterm.pages.dev |
| Branch Preview URL: | https://test-mouse-selection-keys-co.mouseterm.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The nightly survey flagged
handle-mouse-selection-keys.test.tsas covering only two of the handler's paths — the editable-target paste guard and the xterm-helper-textarea paste — leaving the module's core selection logic untested. This adds cases for the untested branches inhandle-mouse-selection-keys.ts, so a regression in any of them fails loudly instead of shipping green.New cases:
nav.paneParamsreportssurfaceType: 'agent-browser'returnsfalseand does not paste, matching the documented invariant that browser/iframe surfaces own their clipboard keys.ewith ahintTokenactive callsextendSelectionToToken(sid, hintToken).setSelection(sid, null).preventDefault) and handled, whileAltis handled but left to reach the OS (the block-selection modifier).Cmd+CcallscopyRawandCmd+Shift+CcallscopyRewrapped, each followed byflashCopywith the matching kind.To drive the drag/selection shape the handler reads, the test now mocks
lib/mouse-selection(the per-id module-state store) alongside the existingclipboardandplatformmocks. The two original tests are unchanged.Test-only change.
vitest run(7 passed) andtsc -bboth pass locally.Surfaced by the nightly code-quality survey.