Skip to content

vendor: update golang.org/x/* dependencies - #7122

Merged
vvoland merged 6 commits into
docker:masterfrom
thaJeztah:bump_x_deps
Jul 27, 2026
Merged

vendor: update golang.org/x/* dependencies#7122
vvoland merged 6 commits into
docker:masterfrom
thaJeztah:bump_x_deps

Conversation

@thaJeztah

Copy link
Copy Markdown
Member

vendor: golang.org/x/sync v0.22.0

semaphore: panic on negative weights

full diff: golang/sync@v0.21.0...v0.22.0

vendor: golang.org/x/sys v0.47.0

  • cpu: handle vendor suffixes in parseRelease
  • unix: update glibc to 2.43
  • unix: use epoll_pwait rather than epoll_wait
  • windows: avoid length overflow in NewNTString
  • windows: document safe usage of TrusteeValue

full diff: golang/sys@v0.46.0...v0.47.0

vendor: golang.org/x/term v0.45.0

full diff: golang/term@v0.44.0...v0.45.0

vendor: golang.org/x/mod v0.38.0

full diff: golang/mod@v0.37.0...v0.38.0

vendor: golang.org/x/text v0.40.0

  • unicode/norm: avoid infinite loop on invalid input

full diff: golang/text@v0.38.0...v0.40.0

vendor: golang.org/x/net v0.57.0

Relevant changes (in vendor):

  • bpf: add security considerations to package docs
  • http2: initialize Transport on NewClientConn
    fixes: x/net/http2: zero Transport not ready for use
  • idna: reject all-ASCII xn-- labels on all Go versions
    fixes x/net/idna: ToUnicode accepts Punycode labels encoding pure ASCII labels

full diff: golang/net@v0.56.0...v0.57.0

vendor: golang.org/x/tools v0.48.0

full diff: golang/tools@v0.47.0...v0.48.0

- Human readable description for the release notes

- A picture of a cute animal (not mandatory but encouraged)

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@docker-agent docker-agent left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 No issues found — LGTM! View logs.

@thaJeztah
thaJeztah requested a review from vvoland July 27, 2026 14:12

@docker-agent docker-agent left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment: 🟢 APPROVE

This is a clean vendor dependency bump for multiple golang.org/x/* packages. All changes are generated or intentional upstream fixes:

  • golang.org/x/sync v0.22.0: semaphore panic-on-negative-weights fix — correct and safe
  • golang.org/x/sys v0.47.0: epoll_pwait unification (null sigmask = identical to epoll_wait), MS_NOUSER constant corrected from -0x80000000 to 0x80000000 (correct bit pattern), NewNTString length overflow guard, TrusteeValueFromString deprecation docs (not called anywhere in docker/cli)
  • golang.org/x/text v0.40.0: unicode/norm infinite loop fix via isInvalid() sentinel using reserved bit 7 (0x80) — explicitly documented as unused in quick-check data
  • golang.org/x/net v0.57.0: http2 Transport init refactor (nil-return impossible due to panic guard in configure()), IDNA all-ASCII xn-- label rejection broadened to all profiles (security fix)
  • golang.org/x/mod v0.38.0, golang.org/x/term v0.45.0, golang.org/x/tools v0.48.0: routine bumps with no behavioral issues found

No bugs introduced by this PR.

vvoland
vvoland previously approved these changes Jul 27, 2026
semaphore: panic on negative weights

full diff: golang/sync@v0.21.0...v0.22.0

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
- cpu: handle vendor suffixes in parseRelease
- unix: update glibc to 2.43
- unix: use epoll_pwait rather than epoll_wait
- windows: avoid length overflow in NewNTString
- windows: document safe usage of TrusteeValue

full diff: golang/sys@v0.46.0...v0.47.0

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
full diff: golang/term@v0.44.0...v0.45.0

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
full diff: golang/mod@v0.37.0...v0.38.0

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
- unicode/norm: avoid infinite loop on invalid input

full diff: golang/text@v0.38.0...v0.40.0

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Relevant changes (in vendor):

- bpf: add security considerations to package docs
- http2: initialize Transport on NewClientConn
  fixes: x/net/http2: zero Transport not ready for use
- idna: reject all-ASCII xn-- labels on all Go versions
  fixes x/net/idna: ToUnicode accepts Punycode labels encoding pure ASCII labels

full diff: golang/net@v0.56.0...v0.57.0

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

@docker-agent docker-agent left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment: 🟢 APPROVE

This PR vendors seven golang.org/x/* dependency updates. All changes are upstream library updates with no application logic changes in docker/cli itself. The vendored changes include important fixes:

  • golang.org/x/text v0.40.0: Infinite-loop fix in unicode/norm for invalid UTF-8 input — correctly implemented
  • golang.org/x/net v0.57.0: HTTP/2 Transport initialization fix and IDNA all-ASCII xn-- label rejection — both correct
  • golang.org/x/sys v0.47.0: epoll_pwait migration (passing NULL sigmask is semantically equivalent to epoll_wait — correct), MS_NOUSER constant corrected to match kernel definition (0x80000000 = 1<<31), and Windows length overflow fix
  • golang.org/x/sync v0.22.0: Semaphore panic-on-negative-weights fix

No bugs introduced by the + lines in this PR.

@vvoland
vvoland merged commit 3320996 into docker:master Jul 27, 2026
97 checks passed
@thaJeztah
thaJeztah deleted the bump_x_deps branch July 27, 2026 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants