vendor: github.com/moby/moby/client v0.5.1 - #7128
Merged
Merged
Conversation
full diff: moby/moby@client/v0.5.0...client/v0.5.1 Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
docker-agent
left a comment
docker-agent
left a comment
Contributor
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
This vendor update (moby/moby/client v0.5.0 → v0.5.1) is a clean, well-scoped improvement. The changes avoid sending unnecessary empty/default query parameters (repo, tag, comment, author in ContainerCommit; insertDefaults in ServiceInspect), add platform deduplication and filtering in service_create.go, and refactor string building in mod.go. All behavioral changes rely on the standard Docker API convention that absent boolean/string parameters are treated identically to false/empty — which is the established API contract.
Lower-confidence findings (not posted inline)
- [low]
vendor/github.com/moby/moby/client/service_inspect.go:31 — ServiceInspect omitsinsertDefaultsparam when false — may change behavior if server interprets absence differently (confidence: weak 45/100) - [low]
vendor/github.com/moby/moby/client/container_commit.go:48 — ContainerCommit no longer sends emptyrepo/tag/comment/authorparams — behavioral change if server distinguishes absent from empty-string (confidence: weak 45/100)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vendor: github.com/moby/moby/client v0.5.1
full diff: moby/moby@client/v0.5.0...client/v0.5.1