blob_db: fix build failure when FLB_SQLDB is flipped off#12158
Open
RaJiska wants to merge 1 commit into
Open
Conversation
Building with flag -DFLB_SQLDB=Off would result undeclared types as some gated includes were required for a successful build. Signed-off-by: Ra'Jiska <dodo.lasticot@gmail.com>
📝 WalkthroughWalkthroughThe changes add blob database header dependencies, conditionally include SQLDB support in the systemd configuration, reorder related includes, and complete SQL-disabled blob database stubs with corrected signatures and unavailable-backend return values. ChangesBlob database compatibility
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
RaJiska
force-pushed
the
worktree-test-minimal-nopgsql
branch
from
July 25, 2026 09:27
90aab82 to
33fdaaa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building with flag -DFLB_SQLDB=Off would result undeclared types as some gated includes were required for a successful build.
Reproducing:
Add
-DDFLB_SQLDB=Offoption to the Dockerfile resulting in build error (logs: before_fix.txt).Changes fix the headers as well as including definitions that were previously missing when SQLDB is turned off, successfully building fluentbit (logs: after_fix.txt)
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.
Summary by CodeRabbit