Remove unused code under screens/ - #9911
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request performs a large-scale cleanup of unused code, imports, and variables across multiple DevTools screens and packages, replacing some assert-based debug initializations with if (kDebugMode) and adding @visibleForTesting annotations. A critical issue was identified in app_size_screen.dart, where removing the value parameter from the stateless DiffTreeTypeDropdown widget introduces a logical bug because it can no longer receive and display the currently selected value from its parent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work towards #9906