Skip to content

Remove unused code under screens/ - #9911

Merged
kenzieschmoll merged 15 commits into
flutter:masterfrom
kenzieschmoll:dcm-2
Jul 27, 2026
Merged

Remove unused code under screens/#9911
kenzieschmoll merged 15 commits into
flutter:masterfrom
kenzieschmoll:dcm-2

Conversation

@kenzieschmoll

Copy link
Copy Markdown
Member

Work towards #9906

@kenzieschmoll
kenzieschmoll requested review from a team, bkonyi and srawlins as code owners July 22, 2026 00:15

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request performs a large-scale cleanup of unused code, imports, and variables across multiple DevTools screens and packages, replacing some assert-based debug initializations with if (kDebugMode) and adding @visibleForTesting annotations. A critical issue was identified in app_size_screen.dart, where removing the value parameter from the stateless DiffTreeTypeDropdown widget introduces a logical bug because it can no longer receive and display the currently selected value from its parent.

Comment thread packages/devtools_app/lib/src/screens/app_size/app_size_screen.dart

@srawlins srawlins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely!

@kenzieschmoll
kenzieschmoll merged commit 86d7bcb into flutter:master Jul 27, 2026
93 of 94 checks passed
@kenzieschmoll
kenzieschmoll deleted the dcm-2 branch July 27, 2026 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants