Trigger re-layout when resizing CPU flame chart - #9915
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses an issue where resizing the CPU flame chart changes timing values by triggering a re-layout of flame chart elements when the container dimensions change, and adds a corresponding widget test. Feedback on the changes suggests optimizing performance by only re-initializing elements when the container width changes (and not the height), and reminds the author to update the placeholder PR link in the release notes.
bkonyi
approved these changes
Jul 27, 2026
bkonyi
left a comment
bkonyi
left a comment
Contributor
There was a problem hiding this comment.
LGTM overall, with one comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7022
When resizing the window, the flame chart's layout width (
widget.containerWidth) changes. However, the custom paint widgets likeTimelineGridPainterare repainted with the new width, while the chart elements are still positioned using the old cached width becauseinitFlameChartElements()is only triggered when the data itself changes.