fix(integrations): reject empty --commands-dir in generic raw_options

[jawwad-ali]

Problem

GenericIntegration._resolve_commands_dir has a parity gap between its two resolution branches:

commands_dir = parsed_options.get("commands_dir")
if commands_dir:            # parsed branch: empty value correctly falls through
    return commands_dir
...
for i, token in enumerate(tokens):        # raw_options branch: NO emptiness check
    if token == "--commands-dir" and i + 1 < len(tokens):
        return tokens[i + 1]              # "" returned verbatim
    if token.startswith("--commands-dir="):
        return token.split("=", 1)[1]     # "" returned verbatim

So specify init --integration generic --integration-options="--commands-dir=" (and --commands-dir "") resolves to "". init's own generic guard (if selected_ai == "generic" and not integration_options) is satisfied because integration_options is the non-empty string "--commands-dir=", so it doesn't catch it. setup() then computes dest = (project_root / "").resolve() == project_root, passes the containment check, and writes every speckit command file (specify.md, plan.md, tasks.md, …) directly into the project root — silently bypassing the documented "--commands-dir is required" contract and polluting the repo root.

Verified on main (4d3a428): _resolve_commands_dir({}, {"raw_options": "--commands-dir="}) returns "" (the parsed-options path with the same empty value correctly raises).

Fix

Apply the same non-empty guard the parsed branch already uses to the raw_options branch, so an empty value falls through to the existing raise ValueError("--commands-dir is required …") on every input form (--commands-dir=, --commands-dir ""). Non-empty values resolve exactly as before — no behaviour change for valid usage.

Verification

• New parametrized test_resolve_commands_dir_rejects_empty_raw_value (--commands-dir=, --commands-dir '', --commands-dir ""): fails before (DID NOT RAISE), passes after.
• New test_resolve_commands_dir_accepts_nonempty_raw_value: non-empty raw values still resolve unchanged.
• Full TestGenericIntegration: 35 passed. ruff clean.

---

AI-assisted: authored with Claude Code. I reproduced the project-root resolution on main (empty raw value → "") and confirmed the parsed-options branch already guards it.

[Copilot]

Pull request overview

Fixes generic integration handling so empty raw --commands-dir values cannot write command files into the project root.

Changes:

• Rejects empty raw option values.
• Adds regression tests for empty and valid forms.

Show a summary per file

File	Description
src/specify_cli/integrations/generic/__init__.py	Validates raw command-directory values.
tests/integrations/test_integration_generic.py	Covers empty and non-empty raw values.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 2/2 changed files
• Comments generated: 0
• Review effort level: Medium