api: Remove io.grpc.Uri#isAbsolute() - #12959
Open
jdcormie wants to merge 1 commit into
Open
Conversation
Javadoc says this method only exists for compatibility with java.net.URI but the meaning of "absolute" actually changed from RFC 2396 to 3986 so isAbsolute() is more of a trap than a convenience. io.grpc.Uri intentionally only models URIs, not URI references. So under the RFC 2396 definition of absolute, every instance is absolute because it has a scheme. Removing isAbsolute() also avoids confusion with absolute paths, an entirely different concept.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Javadoc says this method only exists for compatibility with java.net.URI but the meaning of "absolute" actually changed from RFC 2396 to 3986 so isAbsolute() is more of a trap than a convenience.
io.grpc.Uri intentionally only models URIs, not URI references. So under the RFC 2396 definition of absolute, every instance is absolute because it has a scheme.
Removing isAbsolute() also avoids confusion with absolute paths, an entirely different concept.