fix(DataTableToolbar): apply default bottom spacing - #1759
Open
khushal-winner wants to merge 1 commit into
Open
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthrough
ChangesDataTableToolbar spacing
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Author
|
@KhushamBansal , is it good to go? |
Contributor
There was a problem hiding this comment.
@khushal-winner I don't think we need a test for the sx override, since inline styles already take precedence. Could you remove the additional changes in DataTableToolbar.test.tsx?
Reduces marginBottom from theme.spacing(4) to theme.spacing(2) so consumers inherit the toolbar-to-table gap without per-call-site sx overrides. Callers can still override via sx. Closes layer5io#1719 Signed-off-by: Khushal Malhotra <redmi5a3217@gmail.com>
khushal-winner
force-pushed
the
fix/datatable-toolbar-bottom-spacing
branch
from
July 30, 2026 18:14
750e480 to
850ed5a
Compare
Author
|
@KhushamBansal done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduces marginBottom from theme.spacing(4) to theme.spacing(2) so consumers inherit the toolbar-to-table gap without per-call-site sx overrides. Callers can still override via sx.
Closes #1719
Notes for Reviewers
This PR fixes #
Signed commits
Summary by CodeRabbit