Skip to content

fix(network): prevent UnicodeDecodeError in Request.post_data for non-UTF8 bodies (fixes #3098) #3159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
atiqur-rahman-pro wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

fix(network): prevent UnicodeDecodeError in Request.post_data for non-UTF8 bodies (fixes #3098) #3159

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions playwright/_impl/_network.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,10 +209,10 @@ async def sizes(self) -> RequestSizes:
def post_data(self) -> Optional[str]:
data = self._fallback_overrides.post_data_buffer
if data:
return data.decode()
return data.decode(errors="replace")
base64_post_data = self._initializer.get("postData")
if base64_post_data is not None:
return base64.b64decode(base64_post_data).decode()
return base64.b64decode(base64_post_data).decode(errors="replace")
return None

@property
Expand Down