fix(ui): drop redundant outer frame card on Domain & Data Product docs#30450
fix(ui): drop redundant outer frame card on Domain & Data Product docs#30450siddhant1 wants to merge 5 commits into
Conversation
The Documentation tab on Domain and Data Product detail pages renders the Description as the sole left-panel widget, so the standard left-panel frame card wrapped the Description's own card — a redundant double card with an uneven gap at the bottom. Add an opt-in `flat` variant to GenericTab that drops the left-panel frame (background / border / shadow) and its inner padding, leaving a single Description card flush-aligned with the tabs (left) and the right panel (top). Every other entity type is unchanged because the variant defaults to `default`, so pages whose left panel legitimately holds multiple sections keep their frame. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
❌ PR checklist incompleteThis PR cannot be merged until the following are addressed on its linked issue:
The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically. Maintainers can bypass this check by adding the |
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
Code Review ✅ ApprovedRemoves the redundant outer frame card on Domain and Data Product documentation tabs by adding an opt-in 'flat' variant to GenericTab. No issues found. OptionsDisplay: compact → Showing less information. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
✅ Playwright Results — workflow succeededValidated commit ✅ 536 passed · ❌ 0 failed · 🟡 1 flaky · ⏭️ 5 skipped · 🧰 0 lifecycle flaky PerformanceBlocking targets: ✅ met · Optimization targets: 🟡 in progress Shard-job maxima below are not the full workflow wall time; the linked run includes build, fixture, planning, and reporting. 🕒 Full workflow signal wall (to summary) 48m 36s ⏱️ Max setup 3m 6s · max shard execution 14m 30s · max shard-job elapsed before upload 17m 34s · reporting 5s 🌐 202.74 requests/attempt · 2.86 app boots/UI scenario · 20.57% common-shard skew Optimization targets still in progress:
🟡 1 flaky test(s) (passed on retry)
How to debug locally# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip # view trace |
Code Review ✅ ApprovedRemoves the redundant outer frame card on Domain and Data Product documentation tabs by adding an opt-in 'flat' variant to GenericTab. No issues found. OptionsDisplay: compact → Showing less information. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
|



What
On the Documentation tab of Domain and Data Product detail pages, the Description now renders as a single, clean card — flush‑aligned with the tabs on the left and the right‑hand panel on top.
Previously the Description was wrapped in two nested cards: the standard left‑panel frame (its own background + border + shadow, plus a 16px inner padding) and the Description's own
wrapInCardbox. Because both pages place the Description as the sole child of the left panel, the frame just duplicated the card — a double border with an uneven gap at the bottom, and the inner card sat inset ~16px from everything around it.How
variantprop toGenericTab('default' | 'flat', defaults to'default').flatvariant drops the left‑panel frame (background: transparent; border: none; box-shadow: none) and zeroes the frame's inner padding, so the lone Description card lines up flush with the tabs (left) and the right panel (top) instead of being inset by the frame gap.<GenericTab … variant="flat" />.rounded-[10px]→rounded-xl) now that it's the only card and its corners are more visible.Every other entity type (Tables, Dashboards, etc.) is untouched — their left panel legitimately holds multiple sections (Description and Schema), so
variantdefaults to'default'and they keep the frame. Theflat-left-paneloverride is scoped to that class, which is only ever added on these two pages, so nothing else can regress.Before / After
Domain
Data Product
Testing
border: 0 / background: transparent / box-shadow: none.269px) now matches the tabs, and its top (400px) matches the right panel — vs. being offset by one@padding-md(16px) on both axes before.flat-left-panelclass is applied only whenvariant="flat", so no other entity type can regress.🤖 Generated with Claude Code
Greptile Summary
Updates the Domain and Data Product Documentation tabs to use an opt-in flat GenericTab layout that removes the redundant outer frame and adjusts the Description card radius.
Confidence Score: 5/5
The PR appears safe to merge because no new blocking failure eligible for this follow-up review was identified.
No blocking failure remains beyond the issue already communicated in the previous inline thread.
Important Files Changed
Reviews (3): Last reviewed commit: "Merge branch 'main' into remove-descript..." | Re-trigger Greptile