refactor(training): clean up finetune/freeze code readability - #314
Open
KakaruHayate wants to merge 2 commits into
Open
refactor(training): clean up finetune/freeze code readability#314KakaruHayate wants to merge 2 commits into
KakaruHayate wants to merge 2 commits into
Conversation
- reorganize into load_finetune_checkpoint + load_finetune_weights - use clear variable names (checkpoint_path, ignored_prefixes, mismatched_shapes) - replace per-key print loop with summarized rank_zero_info - avoid mutating input state dict in-place - simplify freeze_params with direct named_parameters iteration - delete dead code and dead comments from 2023-era - add actionable ValueError for missing/invalid checkpoint path - add weights_only=True for secure checkpoint loading
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cleanup of the finetune and parameter-freezing loading paths in
BaseTask, preserving the intended training behavior and all existing configuration keys while tightening error handling and checkpoint deserialization.Changes
load_finetune_checkpoint+load_finetune_weightswith clear responsibilitiescheckpoint_path,ignored_prefixes,mismatched_shapes)print()with summarizedrank_zero_infologsfreeze_paramswith directnamed_parameters()iterationweights_only=Trueandmap_location="cpu"Verification
compileallandgit diff --checkpassed