[PR #1303/877e9e72 backport][3.32] Fix Simple API cache poisoning via ?format=json - #1304
Open
patchback[bot] wants to merge 1 commit into
Conversation
2 tasks
Member
|
We need to backport pulp/pulpcore#7890 to core 3.105 to fix the lowerbounds. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #1303 as merged into main (877e9e7).
Summary
PythonApiCacheon the negotiated media type instead of the rawAcceptheader so?format=jsonand HTML negotiation no longer share a cache entry?format=jsonpoison caseTest plan
oci-env test -p pulp_python functional -- -k test_simple_cache -v?format=jsonwarm followed by the same Accept withoutformatreturns HTML 200 (not 500)Made with Cursor