gh-154199: Soft-deprecate ctypes.util.find_msvcrt - #154553
Conversation
Documentation build overview
|
| if '_d.pyd' in importlib.machinery.EXTENSION_SUFFIXES: | ||
| clibname += 'd' | ||
| return clibname+'.dll' | ||
| """Return the name of the VC runtime dll. |
There was a problem hiding this comment.
This renders _get_build_version unused. Can it be removed?
There was a problem hiding this comment.
@ZeroIntensity, as you'll be doing this more often: consider doing deprecation periods for underscored API as well, if there's no harm in keeping things around for a few more years.
Most of the module predates clear docs on what the underscore means, so existing code might use such functions.
There was a problem hiding this comment.
Ah, right, thanks for the reminder. I think this one is okay because I couldn't find any uses of it after a quick code search.
There was a problem hiding this comment.
Yeah, this is more of a general reminder of what to keep in mind.
As for code searches, be careful -- this stuff also predates GitHub's hegemony.
|
This supersedes #154209 which can now be closed? |
3 participants
ctypes.util.find_msvcrt()returns "msvcrt.dll" on clang-cl Windows builds, breakingctypes.get_errno()#154199