gh-154577: Fix data race in Modules/cjkcodecs/multibytecodec.c#154578
Open
xxyzz wants to merge 1 commit into
Open
gh-154577: Fix data race in Modules/cjkcodecs/multibytecodec.c#154578xxyzz wants to merge 1 commit into
Modules/cjkcodecs/multibytecodec.c#154578xxyzz wants to merge 1 commit into
Conversation
BHUVANSH855
reviewed
Jul 26, 2026
BHUVANSH855
left a comment
BHUVANSH855
left a comment
Contributor
There was a problem hiding this comment.
It looks like the failing Docs job is caused by these :c:type: references. Since MultibyteIncrementalEncoderObject and MultibyteIncrementalDecoderObject are internal implementation types rather than documented C API types, Sphinx can't resolve them and reports unresolved c:type references.
Would it make sense to use code literals (MultibyteIncrementalEncoderObject / MultibyteIncrementalDecoderObject) or simply describe them as the incremental encoder/decoder objects instead? That should avoid the documentation warning while still conveying the intent.
Prevent race by adding `@critical_section` to functions that have `MultibyteIncrementalEncoderObject` or `MultibyteIncrementalDecoderObject` argument Fix TSAN-0001 from pythongh-153852
Author
|
Thanks! Docs check should pass now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent race by adding
@critical_sectionto functions that haveMultibyteIncrementalEncoderObjectorMultibyteIncrementalDecoderObjectargumentFix TSAN-0001 from gh-153852
Modules/cjkcodecs/multibytecodec.c#154577