gh-154760: Narrow bare except in email._header_value_parser - #154839
Closed
BHUVANSH855 wants to merge 1 commit into
Closed
gh-154760: Narrow bare except in email._header_value_parser#154839BHUVANSH855 wants to merge 1 commit into
BHUVANSH855 wants to merge 1 commit into
Conversation
Member
|
The issue has nothkng to do with email. Please check the agent output before submitting. It is wasting reviewer's time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace a bare
exceptinemail._header_value_parser.get_parameter()withexcept errors.HeaderParseError.Rationale
get_extended_attrtext()is the only operation inside thetryblock. Itraises
errors.HeaderParseErrorfor the parse failures this code is intendedto recover from. Narrowing the exception handler avoids suppressing unrelated
exceptions while preserving the existing recovery behavior.
I verified that the recovery path is exercised by the existing test suite and
that
HeaderParseErroris the expected exception for this code path.Tests
./python -m test test_email.test__header_value_parser test_email.test_headerregistry./python -m test test_email