Android fixes - #154895
Open
mhsmith wants to merge 3 commits into
Open
Conversation
Member
|
Can you have a better title? it does not really say what it does |
Member
Author
|
Sorry, description updated. There isn't really a better title, since the only thing these bugs have in common is Android, but since they're all very small,I thought it was better to put them all in the same PR to avoid multiplying the backports. |
Documentation build overview
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarify that the user-facing Android and iOS versions can be found in
platform.release, notplatform.version, which is a kernel build number that's much less likely to be useful.Don't capture stderr from android-env.py. This allows it to display the message "Installing NDK - this may take several minutes", which is quite important, otherwise the user will probably think the script has hung.
Previously the NDK was detected only by checking for the existence of its directory, which will be left in an unusable state by interrupted installations. Fixed by checking for the package.xml file, which sdkmanager creates after installation is complete.
Fix a couple of warnings found by linters: use of an undefined
payloadvariable inAndroid/__main__.py, and defining an unuseditvariable inMainActivity.kt.