Skip to content

Wait for polling queries in logging tests instead of sleeping #775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wintan1418 wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −4
Open

Wait for polling queries in logging tests instead of sleeping #775

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions test/unit/dispatcher_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,15 +38,17 @@ class DispatcherTest < ActiveSupport::TestCase

test "polling queries are logged" do
log = StringIO.new
polling_query = /SELECT .* FROM .solid_queue_scheduled_executions. WHERE/

with_active_record_logger(ActiveSupport::Logger.new(log)) do
with_polling(silence: false) do
rewind_io(log)
@dispatcher.start
sleep 0.5.second
wait_while_with_timeout(3.seconds) { !log.string.match?(polling_query) }
end
end

assert_match /SELECT .* FROM .solid_queue_scheduled_executions. WHERE/, log.string
assert_match polling_query, log.string
end

test "polling queries can be silenced" do
Expand Down
6 changes: 4 additions & 2 deletions test/unit/worker_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,14 +146,16 @@ class WorkerTest < ActiveSupport::TestCase

test "polling queries are logged" do
log = StringIO.new
polling_query = /SELECT .* FROM .solid_queue_ready_executions. WHERE .solid_queue_ready_executions...queue_name./

with_active_record_logger(ActiveSupport::Logger.new(log)) do
with_polling(silence: false) do
@worker.start
sleep 0.2
wait_while_with_timeout(3.seconds) { !log.string.match?(polling_query) }
end
end

assert_match /SELECT .* FROM .solid_queue_ready_executions. WHERE .solid_queue_ready_executions...queue_name./, log.string
assert_match polling_query, log.string
end

test "polling queries can be silenced" do
Expand Down
Loading