feat(json): add Rollup 5 compatibility#2017
Open
TrickyPi wants to merge 1 commit into
Open
Conversation
TrickyPi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
jsonThis PR contains:
Are tests included?
Breaking Changes?
If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers:
related to rollup/rollup#6266
Description
Rollup 5 will support importing the same module with different import attributes. As a result, the
idpassed as the second argument to thetransformhook may include encoded import attributes, causing the existingid.slice(-5) !== '.json'check to incorrectly skip JSON modules.This PR uses
transformOptions.rawIdfor the JSON extension check when it is available and falls back toidfor compatibility with earlier Rollup versions.