fix: broken links reported by the learn site link check#839
Merged
Conversation
The MyST link in the docs guide had no scheme, so it built as the
site-relative path `/developmentmystmd.org`.
The explicit `(unit-tests)=` target in the testing principles collided
with the implicit heading target from `## Unit tests` in the GitHub
Actions guide, so both `{ref}` uses pointed at the wrong page. Rename it
to `unit-tests-principles`.
Assisted-by: ClaudeCode:claude-opus-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
The
netlify-plugin-checklinksrun on learn.scientific-python.org reported 4 failures in/development/, which is built from this repo. This fixes 3 of them.docs/guides/docs.md: the MyST link had no scheme, so it built as the site-relative path/developmentmystmd.organd 404d.docs/principles/testing.md: the explicit(unit-tests)=target collided with the implicit heading target from## Unit testsindocs/guides/gha_basic.md. MyST resolved both{ref}uses to the GitHub Actions guide instead of the section on the same page. Renamed tounit-tests-principles.Checked with a local
myst build --html: the built page now links to#unit-tests-principlesandhttps://mystmd.org.The 4th failure is
/development/guides/pytest#configuring-pytest. The link works; MyST writes cross-page URLs without a trailing slash and Netlify redirects, whichhyperlinkreports asfragment-redirect. That needs a change on the learn site, not here.📚 Documentation preview 📚: https://scientific-python-cookie--839.org.readthedocs.build/