test(copilot): catch a tool silently dropping its query from the chip#5953
Draft
j15z wants to merge 1 commit into
Draft
test(copilot): catch a tool silently dropping its query from the chip#5953j15z wants to merge 1 commit into
j15z wants to merge 1 commit into
Conversation
The "has an intentional display title for every visible catalog tool" assertion only checks that a title exists. A bare fallback label satisfies it exactly as well as the useful one, so a tool that DID show its query can lose that behavior with the suite still green — a coarse check contented by a degraded state. Adds a subset ratchet: any catalog tool that takes a `query` must show it, unless it is in a documented allowlist. The set may shrink, never grow, so removing a tool or teaching one to show its query needs no update here. Baselines the three tools that ignore their query today rather than changing their chips — making the rule true everywhere is a UX change and does not belong in a test-hardening commit. Verified by removing an entry from the allowlist: the assertion fails with the offending tool named.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
has an intentional display title for every visible catalog toolonly checks that a title exists. A bare fallback label satisfies it exactly as well as a useful one, so a tool that shows its query in the chip can stop doing so with the suite still green.Adds a subset ratchet: any catalog tool taking a
querymust show it, unless listed in a documented allowlist. The set may shrink but never grow, so removing a tool — or teaching one to show its query — needs no change here.Three tools currently ignore their query and are baselined with the reason recorded:
search_documentationandsearch_library_docshave no argument-aware case, andsearch_onlinehas one that readstoolTitle/titlewithout falling back toquery. Changing their chips is a UX decision that does not belong in a test-hardening change.Type of Change
Testing
Verified the assertion actually fires — removing an entry from the allowlist fails with the offending tool named:
52 tool-display tests pass, tsc clean, biome clean.
Reviewers should focus on whether the allowlist is the right shape: a subset check keeps the invariant honest about today's state while still catching a regression, but it does mean the three baselined tools are not enforced until someone removes them.
Checklist