Skip to content

improvement(settings): match standalone shell chrome to the workspace one - #5992

Merged
TheodoreSpeaks merged 1 commit into
stagingfrom
improvement/settings-shell-chrome
Jul 28, 2026
Merged

improvement(settings): match standalone shell chrome to the workspace one#5992
TheodoreSpeaks merged 1 commit into
stagingfrom
improvement/settings-shell-chrome

Conversation

@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator

Summary

  • Account, organization, and self-host settings framed both columns in a rounded border and sat the pair inside an outer p-2, so the same section looked different depending on whether it was reached from inside a workspace
  • Now mirrors WorkspaceChrome: the sidebar column is flush and borderless against --surface-1, and only the content pane carries the rounded border

Follow-up to #5990.

Type of Change

  • Improvement

Testing

Tested manually. type-check, lint, all 11 CI audits, and the settings tests pass.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

… one

Account, organization, and self-host settings framed both columns in a
rounded border and sat the pair inside an outer p-2, so the same section
looked different depending on whether it was reached from a workspace.

Mirrors WorkspaceChrome instead: the sidebar column is flush and
borderless against the app surface, and only the content pane carries the
rounded border.
@vercel

vercel Bot commented Jul 28, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Jul 28, 2026 12:09am

Request Review

@cursor

cursor Bot commented Jul 28, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
CSS/layout-only change in the settings shell with no logic, routing, or data handling impact.

Overview
Standalone settings (account, organization, self-host) now use the same shell layout as in-workspace settings via WorkspaceChrome.

The outer wrapper no longer applies p-2 around both columns. The sidebar is flush on --surface-1 with no rounded border or gap (mr-2 removed). Only the main content sits in a padded column (p-[8px] pl-0) with the rounded border and --bg background.

A short comment documents that standalone and workspace settings chrome should stay aligned.

Reviewed by Cursor Bugbot for commit a02d11e. Bugbot is set up for automated code reviews on this repo. Configure here.

@greptile-apps

greptile-apps Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Aligns standalone settings shell chrome with in-workspace WorkspaceChrome layout.

  • Removes outer p-2 and dual bordered columns from StandaloneSettingsShell
  • Makes the sidebar flush/borderless on --surface-1 and wraps only the content pane with p-[8px] pl-0 plus rounded bordered main

Confidence Score: 5/5

Safe to merge; this is a pure visual layout alignment with no behavioral or security impact.

The shell still fills the viewport, content pane border/radius matches WorkspaceChrome, and SettingsSidebar keeps its own overflow-y-auto scroll region so aside overflow-hidden does not clip navigation.

Important Files Changed

Filename Overview
apps/sim/components/settings/standalone-settings-shell.tsx Layout-only chrome tweak to match WorkspaceChrome; no logic or contract changes.

Reviews (1): Last reviewed commit: "improvement(settings): match standalone ..." | Re-trigger Greptile

@TheodoreSpeaks
TheodoreSpeaks merged commit fc396fc into staging Jul 28, 2026
20 checks passed
@TheodoreSpeaks
TheodoreSpeaks deleted the improvement/settings-shell-chrome branch July 28, 2026 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant