improvement(settings): match standalone shell chrome to the workspace one - #5992
Conversation
… one Account, organization, and self-host settings framed both columns in a rounded border and sat the pair inside an outer p-2, so the same section looked different depending on whether it was reached from a workspace. Mirrors WorkspaceChrome instead: the sidebar column is flush and borderless against the app surface, and only the content pane carries the rounded border.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryLow Risk Overview The outer wrapper no longer applies A short comment documents that standalone and workspace settings chrome should stay aligned. Reviewed by Cursor Bugbot for commit a02d11e. Bugbot is set up for automated code reviews on this repo. Configure here. |
Greptile SummaryAligns standalone settings shell chrome with in-workspace WorkspaceChrome layout.
Confidence Score: 5/5Safe to merge; this is a pure visual layout alignment with no behavioral or security impact. The shell still fills the viewport, content pane border/radius matches WorkspaceChrome, and SettingsSidebar keeps its own overflow-y-auto scroll region so aside overflow-hidden does not clip navigation.
|
| Filename | Overview |
|---|---|
| apps/sim/components/settings/standalone-settings-shell.tsx | Layout-only chrome tweak to match WorkspaceChrome; no logic or contract changes. |
Reviews (1): Last reviewed commit: "improvement(settings): match standalone ..." | Re-trigger Greptile
Summary
p-2, so the same section looked different depending on whether it was reached from inside a workspaceWorkspaceChrome: the sidebar column is flush and borderless against--surface-1, and only the content pane carries the rounded borderFollow-up to #5990.
Type of Change
Testing
Tested manually.
type-check,lint, all 11 CI audits, and the settings tests pass.Checklist