fix: return no-JS form submissions to the submitting page when an action returns json()#2245
Open
birkskyum wants to merge 1 commit into
Open
fix: return no-JS form submissions to the submitting page when an action returns json()#2245birkskyum wants to merge 1 commit into
birkskyum wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: cac5d18 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for solid-start-landing-page ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without JavaScript, a form posting to an action that returns
json()orreload()got a 302 with noLocationheader, leaving the browser parked on/_server?id=.... These responses carry a value rather than a destination, sohandleNoJSnever set a redirect target.Responsehas noLocationcustomBody()into the flash cookie souseSubmission().resultmatches the JS path (it previously serialized theResponseto{})inputagainst an empty argument listAdds a no-JS e2e suite covering
json(),reload(),redirect(), and a plain return. The first two fail onmainand pass here; the latter two were already correct.