fix: keep route module ids ending in a real extension so ecosystem plugins match#2249
Open
birkskyum wants to merge 2 commits into
Conversation
|
✅ Deploy Preview for solid-start-landing-page ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…sion-so-ecosystem-plugins-match
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Route files are imported through an id carrying the picked exports in the query (
routes/api.ts?pick=GET). That leaves the id ending inGET, so any plugin whose filter is anchored on the file extension silently skips route files.unplugin-macrosis one example: its defaultincludeis/\.[cm]?[jt]sx?$/, so macros in route files are never expanded and evaluate at runtime instead of build time.toPickId()now appends alang.<ext>marker (routes/api.ts?pick=GET&lang.ts), the same convention Vue SFCs use for?vue&type=script&lang.ts. The id ends in a real extension again and those filters match.The old id shape produced short chunk names only by accident, since
extname()swallowed the entire query. Exposing the query turnedindex-<hash>.jsintoindex.tsx_pick_default_pick__css_lang-<hash>.js, and client chunk filenames are public URLs.sanitizeChunkFileNamestrips the pick tail before applying rolldown's own rules, so names and hashes are unchanged from before.Verifying
With a stock
Macros()and no user filter config, a macro import in a route file:function getRandom() { return Math.random() }random: .2652779648920326GET /macrox3Dev and production both serve routes at 200 with CSS links, modulepreloads and manifest keys intact. Adds unit tests for
toPickIdandsanitizeChunkFileName; the existingtreeshakeandserver-secret-leaktests inapps/testsstill pass.