Fixed #1061, Fixed #1080 Failed Snippets Tests#1162
Conversation
|
Review these changes at https://app.gitnotebooks.com/stumpy-dev/stumpy/pull/1162 |
|
Now that we've confirmed that the unit tests are failing as expected, we can now add the code to fix this |
|
@NimaSarajpoor Please review at your earliest convenience. After this, I will make modifications to the |
NimaSarajpoor
left a comment
There was a problem hiding this comment.
Awesome. I've added a couple of comments for your consideration.
|
Sharing here before I forget: once this is merged, #1080 can be closed. |
I added the failing unit tests (found in those comments) to this PR |
|
Alright @NimaSarajpoor, I'm pretty happy with this PR. However, in an abundance of caution I'm actually going to leave this PR open until we encounter three (3) more of the same snippets errors (the main branch doesn't have this fix yet so we should continue to see ocassional failed snippets tests). Then, one-by-one, I will add them to the unit tests here to see if they are fixed by our PR. If so, then I will merge it. 3 Failing Test Cases:
|
np.sumfor array with many small floating point numbers #1080Pull Request Checklist
Below is a simple checklist but please do not hesitate to ask for assistance!
black(i.e.,python -m pip install blackorconda install -c conda-forge black)flake8(i.e.,python -m pip install flake8orconda install -c conda-forge flake8)pytest-cov(i.e.,python -m pip install pytest-covorconda install -c conda-forge pytest-cov)black --exclude=".*\.ipynb" --extend-exclude=".venv" --diff ./in the root stumpy directoryflake8 --extend-exclude=.venv ./in the root stumpy directory./setup.sh dev && ./test.shin the root stumpy directory