Skip to content

Fixed #1061, Fixed #1080 Failed Snippets Tests#1162

Open
seanlaw wants to merge 4 commits into
stumpy-dev:mainfrom
seanlaw:fix_failing_snippets_tests
Open

Fixed #1061, Fixed #1080 Failed Snippets Tests#1162
seanlaw wants to merge 4 commits into
stumpy-dev:mainfrom
seanlaw:fix_failing_snippets_tests

Conversation

@seanlaw

@seanlaw seanlaw commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Pull Request Checklist

Below is a simple checklist but please do not hesitate to ask for assistance!

  • Read our Contributing Guide
  • Referenced a Github issue (or create one if one doesn't already exist)
  • Left a meaningful comment on the original Github issue to discuss the detailed approach for your contribution
  • Forked, cloned, and checkedout the newest version of the code
  • Created a new branch
  • Made necessary code changes
  • Installed black (i.e., python -m pip install black or conda install -c conda-forge black)
  • Installed flake8 (i.e., python -m pip install flake8 or conda install -c conda-forge flake8)
  • Installed pytest-cov (i.e., python -m pip install pytest-cov or conda install -c conda-forge pytest-cov)
  • Ran black --exclude=".*\.ipynb" --extend-exclude=".venv" --diff ./ in the root stumpy directory
  • Ran flake8 --extend-exclude=.venv ./ in the root stumpy directory
  • Ran ./setup.sh dev && ./test.sh in the root stumpy directory

@gitnotebooks

gitnotebooks Bot commented Jul 25, 2026

Copy link
Copy Markdown

Review these changes at https://app.gitnotebooks.com/stumpy-dev/stumpy/pull/1162

@seanlaw

seanlaw commented Jul 25, 2026

Copy link
Copy Markdown
Contributor Author

Now that we've confirmed that the unit tests are failing as expected, we can now add the code to fix this

@seanlaw
seanlaw requested a review from NimaSarajpoor July 25, 2026 11:57
@seanlaw

seanlaw commented Jul 25, 2026

Copy link
Copy Markdown
Contributor Author

@NimaSarajpoor Please review at your earliest convenience.

After this, I will make modifications to the tests/test_snippets.py and tests/test_aampdist_snippets.py files to also add a precomputed D (distance profiles) that should help ensure that the precision issue is resolved. Then, this can be merged

@NimaSarajpoor NimaSarajpoor left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. I've added a couple of comments for your consideration.

Comment thread tests/test_precision.py Outdated
Comment thread tests/test_precision.py
Comment thread tests/test_precision.py
@NimaSarajpoor

Copy link
Copy Markdown
Collaborator

Sharing here before I forget: once this is merged, #1080 can be closed.

@seanlaw

seanlaw commented Jul 26, 2026

Copy link
Copy Markdown
Contributor Author

Sharing here before I forget: once this is merged, #1080 can be closed.

I added the failing unit tests (found in those comments) to this PR

@seanlaw seanlaw changed the title Fixed #1061 Failed Snippets Tests Fixed #1061, Fixed #1080 Failed Snippets Tests Jul 26, 2026
@seanlaw

seanlaw commented Jul 26, 2026

Copy link
Copy Markdown
Contributor Author

Alright @NimaSarajpoor, I'm pretty happy with this PR. However, in an abundance of caution I'm actually going to leave this PR open until we encounter three (3) more of the same snippets errors (the main branch doesn't have this fix yet so we should continue to see ocassional failed snippets tests). Then, one-by-one, I will add them to the unit tests here to see if they are fixed by our PR. If so, then I will merge it.

3 Failing Test Cases:

  • STUMPY_SEED=<seed>
  • STUMPY_SEED=<seed>
  • STUMPY_SEED=<seed>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

unit testing failure for snippets

2 participants